Skip to content

Default the scripts base to ProxmoxVE - #76

Merged
MickLesk merged 1 commit into
mainfrom
fix/default-scripts-base-ve
Sep 29, 2026
Merged

MickLesk merged 1 commit into
mainfrom
fix/default-scripts-base-ve

Conversation

@MickLesk

@MickLesk MickLesk commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

✍️ Description

A script that does not name its repo now loads its install/ script from ProxmoxVE instead of ProxmoxVED, so a missing pin fails while testing rather than for users. Every other ProxmoxVED fallback in the engine moves with it.

ProxmoxVED pins its own base since community-scripts/ProxmoxVED@f1a0624f. The 613 pins in ProxmoxVE become redundant; community-scripts/ProxmoxVE#17585 drops them and has to merge after this one.

🔗 Related Issue

–

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

A script that does not name its repo now loads install/ from production
instead of the testing repo, so a missing pin fails while testing rather than
for users. ProxmoxVED pins its own base as of
community-scripts/ProxmoxVED@f1a0624f.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/default-scripts-base-ve \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches both backends. Worth running on a Proxmox VE and an Incus host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/default-scripts-base-ve/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/default-scripts-base-ve

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk merged commit 3a7e2a6 into main Sep 29, 2026
4 checks passed
MickLesk added a commit to community-scripts/ProxmoxVE that referenced this pull request Sep 29, 2026
ProxmoxVE is the engine's default scripts base as of community-scripts/core#76,
so the pin no longer changes anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant